refactor: reorganize message handling for better type safety and clarity #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move memory stream type definitions to models.py and use them throughout the codebase for better type safety and maintainability. GitHub-Issue:#201
Updates test files to work with the ParsedMessage stream type aliases and fixes a line length issue in test_201_client_hangs_on_logging.py. Github-Issue:#201
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…ation 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
dsp-ant
force-pushed
the
davidsp/raw-request
branch
from
2e3388b to
0d651d5
Compare
dsp-ant
requested review from
jerome3o-anthropic,
jspahrsummers and
bhosmer-ant
and removed request for
jerome3o-anthropic
bhosmer-ant
approved these changes
Mar 4, 2025
| @@ -22,10 +22,10 @@ | |||
| @pytest.mark.anyio | |||
| async def test_client_session_initialize(): | |||
| client_to_server_send, client_to_server_receive = anyio.create_memory_object_stream[ | |||
| JSONRPCMessage | |||
| MessageFrame[None] | |||
There was a problem hiding this comment.
Should it be MessageFrame[NoneType]?
| RawT = TypeVar("RawT") | ||
|
|
||
|
|
||
| class MessageFrame(BaseModel, Generic[RawT]): |
There was a problem hiding this comment.
Don't know how fastidious we are about this in general, but fwiw the other classes here are docstringed up pretty thoroughly (and the point of raw in particular might be worth noting here)
|
|
||
| class MessageFrame(BaseModel, Generic[RawT]): | ||
| root: JSONRPCMessage | ||
| raw: RawT | None = None |
There was a problem hiding this comment.
Looks like all the uses of MessageFrame pass raw=None explicitly - personally seems nice to require that but maybe there are ergo concerns I'm not thinking of? (Minor side benefit to removing the default would be avoiding the usual union-vs-sum confusion when RawT = T | None...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
GitHub-Issue:#201