Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Client websocket.py #179

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

calclavia
Copy link

@calclavia calclavia commented Jan 29, 2025

Adds a WebSocket client.

Motivation and Context

Currently, there's a WebSocket server but no client. Allows Python clients to connect to WS servers.

How Has This Been Tested?

This is a draft PR. If there's interest in this, then we can move on to adding a test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@jalleyne
Copy link

jalleyne commented Feb 6, 2025

@calclavia thanks for pushing this draft, I'd love to see tests and happy to assist.

@akaashdash
Copy link

any update on this?

@calclavia
Copy link
Author

any update on this?

Hey, sorry I missed this thread. Will run some tests and update!

@calclavia calclavia marked this pull request as ready for review March 7, 2025 14:02
@calclavia
Copy link
Author

@Kludex I addressed your comments by fixing it. Also added a test and that new test passes.

@Kludex
Copy link

Kludex commented Mar 7, 2025

Btw, I'm not a maintainer here. I was just passing by.

@calclavia
Copy link
Author

My bad - notifying @jalleyne

Copy link
Contributor

@jerome3o-anthropic jerome3o-anthropic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome - I've had a play with it locally and it works well. Once the requested changes are in I'm happy to merge

@calclavia
Copy link
Author

@jerome3o-anthropic Addressed comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants