-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Implement support for client_credentials
#1020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LucaButBoring
wants to merge
16
commits into
modelcontextprotocol:main
Choose a base branch
from
LucaButBoring:feat/client-credentials
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Implement support for client_credentials
#1020
LucaButBoring
wants to merge
16
commits into
modelcontextprotocol:main
from
LucaButBoring:feat/client-credentials
+1,355
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements support for the
client_credentials
flow overclient_secret_basic
/client_secret_post
. Requires the client to explicitly declare support for theclient_credentials
grant type, as demonstrated in the example code.Motivation and Context
Enables machine-to-machine auth and using IdPs that don't support a code grant flow.
How Has This Been Tested?
Added an example that integrates with Discord using this flow. The example does not use Dynamic Client Registration because the OAuthProvider boilerplate that offers that has the authorization code grant flow baked into it right now. Instead, a dummy client ID and client secret are hardcoded in the
TokenStorage
implementation.Breaking Changes
OAuthClientInformationFull.client_id
is now optional as described in the OAuth 2.1 specification, section 3.2.2.Types of changes
Checklist
Additional context
#709