feat: add tool annotations according to 2025-03-26 spec #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
src/jvmTest/kotlin/client/ClientTest.kt:526
- Consider adding a test case with non-null annotations to validate the behavior when actual annotation data is provided.
annotations = null,
src/commonTest/kotlin/ToolSerializationTest.kt:36
- Consider including a test scenario for serializing/deserializing a Tool with non-null annotations to ensure full coverage of the new feature.
annotations = null,
e5l
previously approved these changes
Apr 10, 2025
|
Hi @e5l, Ill look into it. Thanks for the feedback! |
|
Hi @e5l, shall i add it in the weather server sample? |
|
yep, it would be great |
|
@e5l Is there anything else required from my end to get this PR merged? |
|
Could you run apiDump task and commit the result? |
…nKai/kotlin-sdk into sean/tool-annotations
auto-merge was automatically disabled
April 27, 2025 06:55
Head branch was pushed to by a user without write access
|
@e5l i have commited the result. Should i do so for the other 2 PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Add tool annotations to provide additional properties describing a Tool to clients.
How Has This Been Tested?
NA
Breaking Changes
NA
Types of changes
Checklist
Additional context
References:
https://github.com/modelcontextprotocol/modelcontextprotocol/blob/main/schema/2025-03-26/schema.ts#L737