Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Issue #4 #49

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[Fix] Issue #4 #49

wants to merge 1 commit into from

Conversation

adi-kmt
Copy link

@adi-kmt adi-kmt commented Mar 8, 2025

  1. Remove the double bang operator and replace it with a null check instead.
  2. add try catch in the block for transport send in acatch block

Motivation and Context

Issue #4

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@adi-kmt
1. Remove the double bang operator and replace it with a null check i…
a2e0503 
…nstead.

2. add try catch in the block for transport send in acatch block
adi-kmt
adi-kmt commented Mar 8, 2025
View reviewed changes
src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/shared/Protocol.kt
)
} catch (sendError: Throwable) {
LOGGER.error(sendError) { "Failed to send error response for request: ${request.method} (id: ${request.id})" }
// Optionally implement fallback behavior here
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @e5l, any fallback you have in mind for this?

@adi-kmt
Copy link
Author

adi-kmt commented Mar 8, 2025

Also please tell me how i can test this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adi-kmt