-
Notifications
You must be signed in to change notification settings - Fork 178
Add example Kotlin Notebook demonstrating MCP client #397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
McpClient.ipynb example notebook demonstrating MCP client0fa96a4 to
afb006a
Compare
afb006a to
214e49f
Compare
devcrocod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I’ve left a few comments regarding the dependencies.
Overall, since this is a notebook, I think it would be better to split the code into separate cells and add some md explanations so that it becomes a complete example
samples/notebooks/McpClient.ipynb
Outdated
| "import kotlinx.coroutines.runBlocking\n", | ||
| "import io.modelcontextprotocol.kotlin.sdk.EmptyJsonObject\n", | ||
| "import io.modelcontextprotocol.kotlin.sdk.Implementation\n", | ||
| "import io.modelcontextprotocol.kotlin.sdk.TextContent\n", | ||
| "import io.modelcontextprotocol.kotlin.sdk.client.Client\n", | ||
| "import io.modelcontextprotocol.kotlin.sdk.client.ClientOptions\n", | ||
| "import io.modelcontextprotocol.kotlin.sdk.client.StdioClientTransport\n", | ||
| "import io.modelcontextprotocol.kotlin.sdk.client.StreamableHttpClientTransport\n", | ||
| "import io.ktor.client.HttpClient\n", | ||
| "import io.ktor.client.call.body\n", | ||
| "import io.ktor.client.request.get\n", | ||
| "import kotlinx.serialization.Serializable\n", | ||
| "import kotlinx.serialization.json.JsonObject\n", | ||
| "import io.ktor.client.plugins.logging.*\n", | ||
| "import io.ktor.client.plugins.sse.SSE\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it’s worth creating a descriptor for mcp sdk?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's also a good way to promote it
40985e5 to
37d3358
Compare
a939dcb to
d179c97
Compare
…alization and usage
d179c97 to
2a18d95
Compare
devcrocod
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Add
McpClient.ipynbexample notebook demonstrating MCP clientMotivation and Context
Provide more examples
How Has This Been Tested?
Run Kotlin Notebook locally
Breaking Changes
No
Types of changes
Checklist
Additional context