Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing try catch block for transport send #4

Open
e5l opened this issue Dec 17, 2024 · 2 comments
Open

Add missing try catch block for transport send #4

e5l opened this issue Dec 17, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@e5l
Copy link
Collaborator

e5l commented Dec 17, 2024

Describe the bug

private suspend fun onRequest(request: JSONRPCRequest) {
	….
	transport!!.send( JSONRPCResponse( id = [request.id](http://request.id/), error = JSONRPCError( ErrorCode.Defined.InternalError, message = cause.message ?: "Internal error", ) ) )
}
@e5l e5l added the bug Something isn't working label Dec 17, 2024
@e5l e5l added the good first issue Good for newcomers label Jan 7, 2025
@adi-kmt
Copy link

adi-kmt commented Mar 3, 2025

Hey @e5l, can i pick this up?

@e5l
Copy link
Collaborator Author

e5l commented Mar 3, 2025

Hey @adi-kmt, it would be great!

@adi-kmt adi-kmt mentioned this issue Mar 8, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants