add config parsing for SSE and streamable HTTP transports#483
Closed
al1y wants to merge 4 commits intomodelcontextprotocol:mainfrom
Closed
add config parsing for SSE and streamable HTTP transports#483al1y wants to merge 4 commits intomodelcontextprotocol:mainfrom
al1y wants to merge 4 commits intomodelcontextprotocol:mainfrom
Conversation
41e8d7c to
e1477a4
Compare
olaservo
requested changes
Jun 15, 2025
Member
olaservo
left a comment
There was a problem hiding this comment.
Thanks for the PR and sorry for the wait. I had some minor comments and questions mainly to clarify the logic.
e1477a4 to
a37a922
Compare
0489103 to
e46ae33
Compare
e46ae33 to
8a34260
Compare
Member
|
Hi, not sure if you already saw that there is a CI failure happening here: https://github.com/modelcontextprotocol/inspector/actions/runs/15797660186/job/45442692899?pr=483 |
|
While using he config file is a great option as well, I feel like having just passing in the specific variables would also provide utmost flexibility during development and if containers are in play here a file-based approach only might not be ideal. something like enabling |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation and Context
Currently, the inspector won't parse and load details from an SSE or Streamable HTTP config.
For example, running
node client/bin/start.js --config "C:\path\to\mcp.json" --server my-serverwheremcp.jsoniswill yield
SSE
After these changes, running
node client/bin/start.js --config "C:\path\to\mcp.json" --server my-serverwill yieldStreamable HTTP
Similarly, running
node client/bin/start.js --config "C:\path\to\mcp.json" --server my-serverwheremcp.jsoniswill now yield
How Has This Been Tested?
Manually with local stdio, sse and streamable-http servers, ensuring stdio env vars propagate appropriately.
Extended related automated tests for client using loaded config values in the connect call.
Better test representation would be in client start and proxy but there's currently no existing framework for either.
Breaking Changes
No expected breaking changes
Types of changes
Checklist
Additional context
First contribution, apologies for any errors in process or intent