-
Notifications
You must be signed in to change notification settings - Fork 350
Implement auto-open feature for browser launch on server start #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally on Mac and it works ok, but a few things:
- There are conflicts to be resolved as the branch is behind.
- Yours launches with
http://localhost
rather thanhttp://127.0.0.1
which we're using instead, to comply with OAuth requirements. - Along with new config items comes a form field requirement in the sidebar. We need an affordance to turn this feature off.

@cliffhall I've commited |
77d4050
to
b09e982
Compare
@cliffhall Review please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @moekiorg. Looks good, operates perfectly. Need to do npm run prettier-fix
though.
@kawakamidev It works fine for opening, but the UI configuration field doesn't change the behavior. If I set it to false then close the inspector, when I run the inspector again, it just auto launches. |
The problem here is that for this to work, the setting can't just be stored in the browser's local storage, it also has to write back to a locally stored configuration that will be consulted before the app launches next time. That's tough, since we don't currently have such a file and plumbing backwards from the client to write it would be a pain. Perhaps we should trim this back to the place you originally had it. Just the auto-open, no UI affordance. |
Motivation and Context
This eliminates the manual step of copying URLs and opening browsers, making the development workflow more efficient.
How Has This Been Tested?
Tested on macOS environments with various browsers (Chrome, Firefox, Safari). Verified that the feature respects user configuration and can be disabled via configuration options.
Breaking Changes
No breaking changes. The feature is enabled by default but can be disabled through configuration.
Types of changes
Checklist