Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle integer input #156

Closed

Conversation

olaservo
Copy link
Collaborator

Motivation and Context

Addresses this issue: #154

When the JSON schema specifies an integer, the current implementation displays a text field and ends up sending the input as a string, which isn't compliant with the JSON spec.

Changes made:

  1. Integer Field Handling

    • Added integer input field with type="number" step="1"
    • Convert string values to numbers using Number() with validation
    • Ensures only valid integers are passed to the MCP server
  2. Form Field Improvements

    • Added support for optional fields (undefined values)
    • Added proper handling of required fields
    • Added support for default values from schema
    • Improved null type handling
  3. Value Generation

    • Updated default value generation to only generate default values for required fields
    • Handles undefined and null states
  4. Array and Object Handling

    • Improved array item generation
    • Better handling of nested object properties
    • More robust JSON value type definitions

How Has This Been Tested?

I am still testing this with a real example of a schema with integer type. Will take this out of draft once tested.

Breaking Changes

No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@olaservo
Copy link
Collaborator Author

Closing to add tweaks to this PR instead: #159

@olaservo olaservo closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant