Fixed StreamableHttpClientSessionTransport.cs for netstandard #582
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed exception 'The format of value 'application/json; charset=utf-8' is invalid "application/json; charset=utf-8" is an invalid header. the correct one is "application/json".
halter73
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Thanks. I made this same change in #377.
@eiriktsarpalis I know we run our tests on net9.0 and net8.0, do you think we should include net472? If we did that, we would need to write multi-process tests so ASP.NET Core can still run to get good coverage for the HTTP-based client code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed exception 'The format of value 'application/json; charset=utf-8' is invalid
Motivation and Context
Without this fix it doesn't work at all with .NET Framework.
"application/json; charset=utf-8" is an invalid header when the encoding is already specified. It fails immediately when creating the McpClient instance with the SseClientTransport using netstandard builds.
How Has This Been Tested?
Works. Without the fix doesn't work at all.
Breaking Changes
Not a breaking change.