Skip to content

OpenTelemetry: context propagation and semconv update #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 13, 2025
Merged

OpenTelemetry: context propagation and semconv update #262

merged 9 commits into from
Apr 13, 2025

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Apr 10, 2025 •
edited
Loading

This is a prototype of open-telemetry/semantic-conventions#2083:

  • includes client to server context propagation
  • more MCP and less JSON RPC context
  • disable spans for log notification - they are written as logs

TODO:

  • tests
  • docs, especially for server developers on how to enable OTel with less boilerplate
  • clean up examples

stephentoub
stephentoub reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@lmolkova lmolkova force-pushed the otel-additional-instrumentation branch from 3e244ee to 27f58c8 Compare April 12, 2025 00:39
@lmolkova lmolkova changed the title [WIP] OpenTelemety: context propagation and semconv prototype OpenTelemetry: context propagation and semconv update Apr 12, 2025
@lmolkova lmolkova marked this pull request as ready for review April 12, 2025 01:12
@stephentoub stephentoub force-pushed the otel-additional-instrumentation branch from 58511c1 to 0bccb94 Compare April 13, 2025 02:05
@stephentoub stephentoub merged commit d6cc65a into modelcontextprotocol:main Apr 13, 2025
7 checks passed
@codefromthecrypt codefromthecrypt mentioned this pull request Apr 28, 2025
Merged
9 tasks
@codefromthecrypt
Copy link
Contributor

fyi I just raised this PR to change the carrier from request.params -> request.params._meta (and backfilled a test)

If you feel strongly propagation fields should be comingled with JSON-RPC params, please mention rationale on the spec PR here.

I think the main goal is to converge on the carrier field so that we can close gaps as right now 2 of 3 known uses are request.params._meta (here is request.params)

@codefromthecrypt codefromthecrypt mentioned this pull request Apr 28, 2025
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lmolkova @codefromthecrypt @stephentoub