Fixed cargo doc failing to compile
#1331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinval
reviewed
Jul 4, 2022
|
Also fixes minor blocker for #1008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
No change to Kani's behavior. Fixes the issue of
cargo doc --workspacerefusing to compile. Cargo doc warnings are fixed in commits b415ff2 - d0154c2.Resolved issues:
Resolves #1282
Call-outs:
Cargo doc still gives errors in non-critical areas.Fixed as of d0154c2rustc_middle. Please check that this is an accurate fix, as I haveno baseline.
Testing:
How is this change tested? Run
cargo doc --workspaceto check that compile issue has been fixed. Manually confirm that doc fixes are reasonable.Is this a refactor change?
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.