Skip to content
This repository was archived by the owner on Apr 24, 2022. It is now read-only.

Update dependencies#20

Closed
brettz9 wants to merge 7 commits intomocha-community:masterfrom
brettz9:npm
Closed

Update dependencies#20
brettz9 wants to merge 7 commits intomocha-community:masterfrom
brettz9:npm

Conversation

@brettz9
Copy link
Copy Markdown
Contributor

@brettz9 brettz9 commented May 30, 2020

  • npm: Update devDeps.
  • npm: Update mocha peer dep.

@munierujp
Copy link
Copy Markdown
Member

@brettz9 Please resolve conflicts.

@brettz9
Copy link
Copy Markdown
Contributor Author

brettz9 commented Jun 1, 2020

Thanks for the review and merge! Resolved/rebased...

@munierujp
Copy link
Copy Markdown
Member

@brettz9 Could you divide PR to keep clean commit logs and versioning?

  • Add .editorconfig
  • Add meta for package.json
  • Add lint script
  • Update dependencies

@brettz9
Copy link
Copy Markdown
Contributor Author

brettz9 commented Jun 3, 2020

By dividing the PR, do you mean 4 separate PRs? (I've already split into 4 commits, and can make separate PRs also if you wish.)

@munierujp
Copy link
Copy Markdown
Member

@brettz9

do you mean 4 separate PRs?

That's right.

@brettz9
Copy link
Copy Markdown
Contributor Author

brettz9 commented Jun 3, 2020

Ok, I've added separate PRs and made this one focus just on updating devDeps.

@munierujp
Copy link
Copy Markdown
Member

This PR will be merged after #21, #22.

@munierujp munierujp changed the title Npm Update dependencies Jun 5, 2020
@brettz9 brettz9 mentioned this pull request Jun 7, 2020
@brettz9
Copy link
Copy Markdown
Contributor Author

brettz9 commented Jun 11, 2020

I've updated and rebased this. Note that it in updating Mocha further to 8.0, it also adds Mocha 8 as a new peer dep. option

@brettz9
Copy link
Copy Markdown
Contributor Author

brettz9 commented Jun 11, 2020

Oh, and thank you for the merges/reviews!

@brettz9
Copy link
Copy Markdown
Contributor Author

brettz9 commented Jun 30, 2020

Could you look to merge this and #24 ? Thanks!

@brettz9
Copy link
Copy Markdown
Contributor Author

brettz9 commented Aug 22, 2020

Bump...

@munierujp
Copy link
Copy Markdown
Member

@brettz9 I'm sorry for the late reply 🙇
Could you divide PR to keep clean commit logs and versioning?

  • Support Mocha 8.x
  • update eslint package
  • update eslint-config-standard package
  • update eslint-plugin-import package
  • update eslint-plugin-node package

BTW: We're planning to use Renovate for managing dependencies as ts-examples does.

@brettz9
Copy link
Copy Markdown
Contributor Author

brettz9 commented Sep 19, 2020

I've already divided this per your earlier instructions into the update of dependencies, and not eager to see the chance for yet more divisions if you are not actually happy with those (e.g., if you change your mind to want mocha 8 for examples and mocha 8 for the main).

Besides that, there may be interactions where one update requires another update (e.g., an eslint plugin needing the eslint update), so at this point, I'm just going to leave this in your hands. Thanks for the other merges...

@munierujp munierujp closed this Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants