fix(orchestra): interpolate appId for driver waits - #3482
Open
xianjianlf2 wants to merge 3 commits into
Open
Conversation
xianjianlf2
force-pushed
the
fix/resolve-templated-app-id-3479
branch
from
August 7, 2026 04:31
f5dbc97 to
1dda5da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MaestroConfigafterDefineVariablesCommandruns.waitForAppToSettlereceive the interpolatedappId.appIdduring tap settling.Fixes #3479
Testing
git diff --check./gradlew :maestro-test:test --tests maestro.test.IntegrationTest --tests 'maestro.test.IntegrationTest.templated appId is used when settling after a tap'(blocked locally: no Java Runtime is installed)