Skip to content

Conversation

@fr0l
Copy link

@fr0l fr0l commented Jul 30, 2024

Proposed changes

Adds feature to generate both reports: JUnit and HTML
Useful for CI, when JUnit XML is consumed by CI, and HTML for People to view.

copilot:summary

Testing

Launching tests with composite report:

maestro \
      test \
      pathToTests \
      --format composite \
      --output "reports_dir/"

Reports will be generated in:

  • reports_dir/JUnit/report.xml
  • reports_dir/Html/report.html

Issues fixed

@fr0l fr0l force-pushed the composite_report branch from 2e15065 to 3b8d428 Compare July 31, 2024 00:01
@bartekpacia
Copy link
Contributor

Hey @fr0l, thanks a lot for this PR. I'll try to allocate some time to review it soon. Meanwhile could you attach images/videos showing what the new report looks like? Thanks!

@fr0l
Copy link
Author

fr0l commented Jul 31, 2024

Hey @fr0l, thanks a lot for this PR. I'll try to allocate some time to review it soon. Meanwhile could you attach images/videos showing what the new report looks like? Thanks!

Hey @bartekpacia , this does not produce a new type of report. it combines two reports. produces JUnit + HTML reports for a test run.

@bartekpacia
Copy link
Contributor

I see.

Could you also update documentation in https://github.com/mobile-dev-inc/maestro-docs/?

@fr0l
Copy link
Author

fr0l commented Aug 14, 2024

Hey @bartekpacia , I've added docs changes here mobile-dev-inc/maestro-docs#70
Preview rendered document is possible here https://github.com/fr0l/maestro-docs/blob/composite_test_report/cli/test-suites-and-reports.md

Thank you!

@fr0l fr0l force-pushed the composite_report branch from 3b8d428 to 0d45e6a Compare August 14, 2024 16:39
@ubuntudroid
Copy link

@bartekpacia any plans to review and merge this?

This seems to also block #1864 which looks fascinating, especially when it comes to increase acceptance for Maestro when introducing it to new teams. Right now, debugging test failures takes more time than it should. The visual approach in #1864 has the potential to improve this immensely.

@Fishbowler Fishbowler self-assigned this Sep 22, 2025
@Fishbowler
Copy link
Contributor

I've rebased this and solved the conflicts

Comment on lines +27 to +33
private fun getBaseReportDirectory(out: File): File {
return if (out.absoluteFile.isDirectory) {
out.absoluteFile
} else {
out.absoluteFile.parentFile
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this attempt to create a directory if one is specified but doesn't yet exist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants