-
Notifications
You must be signed in to change notification settings - Fork 504
Add Composite reporter that generates JUnit and HTML #1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hey @fr0l, thanks a lot for this PR. I'll try to allocate some time to review it soon. Meanwhile could you attach images/videos showing what the new report looks like? Thanks! |
Hey @bartekpacia , this does not produce a new type of report. it combines two reports. produces JUnit + HTML reports for a test run. |
|
I see. Could you also update documentation in https://github.com/mobile-dev-inc/maestro-docs/? |
|
Hey @bartekpacia , I've added docs changes here mobile-dev-inc/maestro-docs#70 Thank you! |
|
@bartekpacia any plans to review and merge this? This seems to also block #1864 which looks fascinating, especially when it comes to increase acceptance for Maestro when introducing it to new teams. Right now, debugging test failures takes more time than it should. The visual approach in #1864 has the potential to improve this immensely. |
0d45e6a to
568f6e1
Compare
|
I've rebased this and solved the conflicts |
| private fun getBaseReportDirectory(out: File): File { | ||
| return if (out.absoluteFile.isDirectory) { | ||
| out.absoluteFile | ||
| } else { | ||
| out.absoluteFile.parentFile | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this attempt to create a directory if one is specified but doesn't yet exist?
Proposed changes
Adds feature to generate both reports: JUnit and HTML
Useful for CI, when JUnit XML is consumed by CI, and HTML for People to view.
copilot:summary
Testing
Launching tests with
compositereport:Reports will be generated in:
reports_dir/JUnit/report.xmlreports_dir/Html/report.htmlIssues fixed