Add bridge launch overrides for tests and bump Pi runtime to v0.1.4#417
Merged
mmprotest merged 1 commit intoJun 29, 2026
Conversation
d76029f
into
mmprotest/implement-pi-integration-as-external-adapter
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
spawn EFTYPEbecause tests passed a fake bridge path that is not directly executable on Node'sspawnwithout usingshell:true.0.1.3to0.1.4and tests/docs needed to reflect the new runtime version.process.execPathwhile keeping production bridge launch semantics unchanged.Description
BridgeLaunchOptions(fieldsexecutableOverride?: stringandbridgeArgsOverride?: string[]) and threaded them intoBridgeProcessOptionsso launches may override the executable and args (file:integrations/pi-villani/src/process.ts).VillaniBridgeProcessuse the launch overrides when present, while preserving production defaults ofspawn(executable, ['bridge','--stdio'], { shell: false, ... })(file:integrations/pi-villani/src/process.ts).bridgeLaunchOptionsthroughassertBridgePing()andrunVillani()and added a helperbridgeLaunchOptions(ctx)to read overrides fromctx(file:integrations/pi-villani/src/index.ts).bridgePing()andrunVillani()withbridgeLaunchOptions: { executableOverride: process.execPath, bridgeArgsOverride: [fakeScript] }so fake bridge scripts are launched asnode fakeScript(file:integrations/pi-villani/src/extension.test.ts).0.1.4and updated README/docs to referencev0.1.4so version consistency tests derive expected names fromVILLANI_RUNTIME_VERSION(file:integrations/pi-villani/src/runtimeConfig.ts,README.md,docs/release.md).Testing
cd integrations/pi-villani && npm run buildwhich compiles TypeScript successfully.cd integrations/pi-villani && npm testwhich executed the test suite (91 tests) and all tests passed (# pass 91 # fail 0).cd integrations/pi-villani && npm pack --dry-runwhich produced a pack listing for@mmprotest/pi-villani@0.1.4successfully.Codex Task