Add a method to JsonSink to allow separate writing of key and value #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
approved these changes
Apr 17, 2024
|
Released as 1.9. It's been a bit of time since I pushed to Maven Central so please check it out if you can. Happy to accept PRs to modernize the build infrastructure as well. |
|
Yes it's all there. Thanks for the quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #89
I added a
keymethod toJsonSink- instead of just adding it toJsonWriterBase. This escalated a tiny bit since I then had to implement the method inJsonBuilderas well, which did not yet have its own test - being covered by theJsonWriterTest, I presume.Although
JsonWriterBasecould immediately write the key to the underlying stream, I also implemented the feature in the "pending key" style, since it will then read very similarly in bothJsonWriterBaseandJsonBuilder.It's not quite clear to me what fields in JSON objects are called, but from the tests/error messages in the library, I picked up that you're calling them "key" :)