Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to check for constant model while focussearch #259

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
+30 −4
Open

add function to check for constant model while focussearch #259

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7d600f4
add function to check for constant model while focussearch
jakob-r Sep 27, 2016
01cd664
constant.model check makes more sense now and it always on
jakob-r Sep 28, 2016
e6a5909
check.constant.model is always on
jakob-r Sep 28, 2016
a7346f7
typo
jakob-r Sep 28, 2016
24f58b7
fix detection
ja-thomas Oct 18, 2016
1e74ab9
Merge branch 'master' into feature_constantModel
jakob-r Oct 19, 2016
69511e3
simplyfy getExtras
jakob-r Nov 24, 2016
0a3b850
Merge branch 'master' into feature_constantModel
jakob-r Nov 24, 2016
1d91141
typo
jakob-r Nov 25, 2016
0f81ee1
Merge branch 'master' into feature_constantModel
jakob-r Nov 25, 2016
a683876
update roxygen files
jakob-r Nov 25, 2016
d62aa8f
Merge branch 'master' into feature_constantModel
jakob-r Apr 7, 2017
f945325
roxgenize
jakob-r Apr 7, 2017
2ef5399
repair test
jakob-r Apr 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
simplyfy getExtras
@jakob-r
jakob-r committed Nov 24, 2016
commit 69511e38b3f06a218bdb3a6d76240b7927ea3ed8
6 changes: 1 addition & 5 deletions R/getExtras.R
View file
Original file line number Diff line number Diff line change
@@ -61,11 +61,7 @@ getExtras = function(n, prop, train.time, control) {
if (control$filter.proposed.points) {
ex$filter.replace = prop$filter.replace[i]
}
if (isTRUE(attr(prop$prop.points, "constant.model"))) {
ex$constant.model = TRUE
} else {
ex$constant.model = FALSE
}
ex$constant.model = isTRUE(attr(prop$prop.points, "constant.model")
# if we use asyn MBO store node information and evaluation starte
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why that complicated?

ex$constant.model = isTRUE(attr(prop$prop.points, "constant.model"))

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRUE

ex$train.time = if (i == 1) train.time else NA_real_
ex$prop.type = prop$prop.type[i]