Skip to content

Cleanups#8

Open
rcurtin wants to merge 7 commits intomlpack:masterfrom
rcurtin:cleanups
Open

Cleanups#8
rcurtin wants to merge 7 commits intomlpack:masterfrom
rcurtin:cleanups

Conversation

@rcurtin
Copy link
Member

@rcurtin rcurtin commented Feb 18, 2026

These aren't really changes to functionality but more changes to organization to bring this into line with the rest of the mlpack code. I made these changes to what used to be the model_parser/ directories:

  • Fix style to match mlpack style (2-space tabs, a few other things)
  • Use size_t instead of int where possible.
  • Don't do using namespace in a header file.
  • Move to onnx_mlpack/ directory (so that all inclusions eventually will be under this directory).
  • Remove onnx_pb.h and use the one provided by the system.

I think that the conversions to/from mlpack/ONNX weight formats can be simplified a lot, but I'll do that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments