Wip/mango 1945/fix failing tests #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing pom.xml code block
Update BACnetTest.java , let it is usable in Release 4.0.1
Update BACnetTest.java , let it is usable in 4.0.1
forwarded if the router was previously unknown.
…e-address' # Conflicts: # README.md # src/main/java/com/serotonin/bacnet4j/LocalDevice.java # src/main/java/com/serotonin/bacnet4j/npdu/Network.java # src/main/java/com/serotonin/bacnet4j/npdu/NetworkUtils.java
add dependabot
Create dependabot.yml
adding sales contact info for license
We recently realized that our GitHub Workflows are potentially unsafe. Delete the dependabot.yml from all the projects in the repo.
Delete .github/workflows/dependabot.yml
* RAD-4123 Allow null values for daily and exception schedule * RAD-4123 Allow null values for daily and exception schedule * Update README.md
RAD-5573 Improve scheduling and validation logic for Schedule Object
Remove Eclipse settings Add IntelliJ settings
Add additional deploy plugin execution
* Add option to update the remote device cache * Make LocalDevice implement AutoClosable * Add test for expirationCheck * Fix case where iAmReceived newDevice is same instance Move callback outside synchronized Make RemoteDeviceDiscoverer implement AutoClosable Add tests for startRemoteDeviceDiscovery method * Add Javadoc, fix imports * Update README.md * Add flatten-maven-plugin
* Add SonarQube workflow.
…Builder to get the Local IP Address, Broadcast Address and Subnet Mask (#109) * MANGO-1817 - fix build methods in IpNetworkBuilder to get the Local IP address, Broadcast and SubnetMask assigned to the NIC. MANGO-1818 - Deprecate withReuseAddress in IpNetworkBuilder as this flag would be set based on the OS MANGO-1832 - Add new method to build the network from the interface name in IpNetworkBuilder Add Unit Tests for the above feature IpNetworkBuilderTest Remove usage withReuseAddress in ahoc/IPMasterTest and adhoc/MultipleLocalDevices Change BACnet4J revision from 6.0.1-SNAPSHOT to 6.1.0-SNAPSHOT * Incorporated the changes as per the review comments. * Improvement - The details of NIC are stored in Record format instead of List of strings. Improvement - Improve the methods in IpNetworkUtils.java Improvement - Improve the formatting of the comments using HTML List, parameter and return definition Improvement - Improve the build methods in IPMaster.java Improvement - pom.xml - Change the source and target java version to 21 from 1.8 to accommodate record type * fix - test failure in BBMDTest.java fix - test failure in IpNetworkBuilderTest.java improvement in comments incoporate review comments * fix - Test failed because mock method is not called * improvement - add Exception handler for incorrect configuration of host * fix - Tests in TrendLog and TrendLogObjects Test fix - Tests in DefaultTransportTest improvement - add Exception handler for incorrect configuration of host * fix - Tests in TrendLog and TrendLogObjects Test fix - Tests in DefaultTransportTest improvement - add Exception handler for incorrect configuration of host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the failed tests in BACnet4J. Tested the new commits in Teamcity and all the tests are passing. Kindly review.