Test train save load, with and without fsdp #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achalddave
reviewed
Dec 11, 2023
|
Thanks for the review Achal. Actually I added a test that the parameters are different after train one epoch but it fails... so I'll solve that and push the fix. |
jmercat
force-pushed
the
test_resume
branch
2 times, most recently
from
c8ee305 to
7086109
Compare
|
I think we can skip the s3 test, it'll be annoying with the CI, and we use --remote-sync pretty commonly anyway. |
jmercat
force-pushed
the
test_resume
branch
2 times, most recently
from
6bf34a8 to
5fadff4
Compare
achalddave
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help address #145, please tell me if I should actually call main as suggested in the issue or if this is fine.