Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimenting with alternative siglip loss impl for better dist scaling #971

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

rwightman
Copy link
Collaborator

@JeniaJitsev
Copy link
Contributor

Very nice, giving it a try

@rwightman
Copy link
Collaborator Author

So gather impl here looks like it's a better balance but still scaling issues wrt to throughput. The additions here allow flexiblility to add other impl that can further improve things so will merge what's here for now.

@rwightman rwightman merged commit aeaf2a0 into main Dec 4, 2024
4 checks passed
@rwightman rwightman deleted the revisit_siglip_loss branch December 4, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants