-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make clip always output dict in open_clip traininig #396
Conversation
@gpucce thanks, rather than is running in openclip, I think it should be open_clip will set to True |
changed to output_dict |
Hey, should the forward in the line 263 of training/train.py contain the output_dict argument? It throws an error for now.. |
@rohan1561 there should be no output dict args in model fwd, don't know why that's still there, guess we missed one @gpucce |
Hi, indeed there should not be, I will make a PR with also a test |
@gpucce I already pushed a quick fix, but PR for a test to cover this case would be good |
This should make clip always use the output dict option when the training is done inside open_clip.
Partially addressing #390 and fixing #395
@rwightman