Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding CoCa #256
adding CoCa #256
Changes from 72 commits
1189487
91d01fa
efb6540
669a3a0
f081dc4
0b1c895
27369b6
d518dd0
11bf57c
f3dedf6
50c4726
1e41d83
0d91609
50e0cbe
93b4236
97e3c0f
6ae6f8c
0975dfe
f2265ec
9d47f0e
6a101ec
e259851
7fff61d
abd132d
452d7d2
43ce18f
3f0f012
3e745ec
4f4d3b7
42539aa
914a570
6215d4a
b97db74
d89f018
9a8c15d
c8b9236
d0f995a
5260774
7a2b84e
3ef1d17
86f47bb
c6834b5
7489c68
59503df
504febd
72a7e96
d8a94be
d250eac
8d9dfa6
1f2578c
d8ff1bd
fa24047
f61f9d5
4b76187
b8777fe
42aa408
1044f36
dab7d7d
d0ae683
5a40804
6789438
60865ef
ac617bf
b9c2b25
ccfd1e4
c1556d4
68d608a
59d4db4
4ee12e1
732f15f
17072c6
74d5e37
578aadf
08f43a3
812a8bb
f69f4e0
3c02aa5
979cef4
2ec204b
29c7dfa
5a4126b
6e49474
288ddf3
599d448
d7953da
e2042d4
15c69f8
c219381
360408e
5c77e4d
3f095a6
60f35f3
a53f477
b3f3d68
8eb4772
cf0f857
d547017
75be611
356fb7d
8008f25
5b54a4b
292fa6e
720dabf
bcb82c4
d0f4947
39f20e6
2dde78d
de4c063
00aa464
b7bea09
27bfc7d
e694999
5427b0a
cc6d13f
abd7849
19300ad
919f5a0
5b29ec0
752de0a
1360fcd
cd91d32
64c33d8
17813eb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the whole local_loss thing not apply here? why is this not like the corresponding part of the ClipLoss
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried, I hope I got it right, I don't know too much about this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iejMac I am replying to all comments I think need a reply and I tag you in the things that I think are more relevant / I understand less.
After thinking a bit more, I think
local_loss
is not really needed in the captioning loss, since, if I gatherlogits
orlabels
then either I gather also the other one or I could have avoided gathering in the first place as the loss is "one by one", while for clip_loss I believe it is implemented to have a smaller matrix product in case of large batch size?