Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coca follow ups #390

Closed
8 of 9 tasks
rom1504 opened this issue Jan 29, 2023 · 8 comments
Closed
8 of 9 tasks

coca follow ups #390

rom1504 opened this issue Jan 29, 2023 · 8 comments

Comments

@rom1504
Copy link
Collaborator

rom1504 commented Jan 29, 2023

@rom1504 rom1504 mentioned this issue Jan 29, 2023
6 tasks
@rwightman
Copy link
Collaborator

@rom1504 that's not 'remove an option to not output a dict', that was the whole point on the model side so other users of the model don't break, it's 'remove support for non-dict mode in train code'

@rom1504
Copy link
Collaborator Author

rom1504 commented Jan 29, 2023

Alright

@vturrisi
Copy link

vturrisi commented Feb 2, 2023

Hey! Thanks for the great effort in making CoCa available.

I was generating captions with CoCa and they work fine with the new beam search implementation. However, I wanted to do top-p/nucleus sampling generation as in BLIP and for that there are a couple of issues with the current implementation. There's no way to enforce minimal number of tokens and the end of sequence token is ignored, so the model will keep generating until the sequence length. I did some quick fixes on my side but since I'm not super familiar with huggingface/openclip that is for sure suboptimal.

I can share more info if needed :)

@gpucce
Copy link
Contributor

gpucce commented Feb 2, 2023

hi @vturrisi I opened a PR here #402 can you try it and see if this is what you expected?

@rom1504
Copy link
Collaborator Author

rom1504 commented Feb 4, 2023

Done. Last point tracked there #409

@rom1504 rom1504 closed this as completed Feb 4, 2023
@lucidrains
Copy link
Contributor

@gpucce thank you for your amazing work Giovanni!

@ludwigschmidt
Copy link
Collaborator

Indeed, awesome work here!

@usuyama
Copy link

usuyama commented Feb 5, 2023

Awesome work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants