-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coca follow ups #390
Comments
@rom1504 that's not 'remove an option to not output a dict', that was the whole point on the model side so other users of the model don't break, it's 'remove support for non-dict mode in train code' |
Alright |
Hey! Thanks for the great effort in making CoCa available. I was generating captions with CoCa and they work fine with the new beam search implementation. However, I wanted to do top-p/nucleus sampling generation as in BLIP and for that there are a couple of issues with the current implementation. There's no way to enforce minimal number of tokens and the end of sequence token is ignored, so the model will keep generating until the sequence length. I did some quick fixes on my side but since I'm not super familiar with huggingface/openclip that is for sure suboptimal. I can share more info if needed :) |
Done. Last point tracked there #409 |
@gpucce thank you for your amazing work Giovanni! |
Indeed, awesome work here! |
Awesome work! |
The text was updated successfully, but these errors were encountered: