Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): update GitHub Actions and npm dependencies #648

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mldangelo
Copy link
Owner

  • Updated GitHub Actions workflows to use newer versions of actions.
  • Upgraded npm dependencies to their latest versions.
  • Updated Node.js version requirements in documentation and configuration files.
    No breaking changes introduced.

Copy link

cloudflare-workers-and-pages bot commented Feb 17, 2025

Deploying mldangelo with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2b11f20
Status:🚫  Build failed.

View logs

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 17, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 17, 2025
@rianbrooksflynn
Copy link

Hi Michael - thank you for creating and maintaining this wonderful repository! I have a fork for my own personal website.

I noticed you were having a bit of trouble with passing the no sandboxing arguments to puppeteer through react-snap. I did a little bit of investigating and figured out that you can just add the following lines to package.json without any need for extra steps of installing Chrome or other dependencies:

  "reactSnap": {
    "puppeteerArgs": [
      "--no-sandbox",
      "--disable-setuid-sandbox"
    ]
  }

(It worked great on my fork, see this commit.)

Only other thing to note is that the actions/upload-pages-artifact GitHub action does not have a v4 yet, only a v3.

- name: Upload artifact
uses: actions/upload-pages-artifact@v2
uses: actions/upload-pages-artifact@v4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only v3 exists for now - see https://github.com/actions/upload-pages-artifact.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rianbrooksflynn! I'll clean this up. The repo is long overdue for an update - I am planning on replacing the build system soon with either vite or next too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants