-
Notifications
You must be signed in to change notification settings - Fork 926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dependencies): update GitHub Actions and npm dependencies #648
base: main
Are you sure you want to change the base?
Conversation
Hi Michael - thank you for creating and maintaining this wonderful repository! I have a fork for my own personal website. I noticed you were having a bit of trouble with passing the no sandboxing arguments to puppeteer through react-snap. I did a little bit of investigating and figured out that you can just add the following lines to
(It worked great on my fork, see this commit.) Only other thing to note is that the |
.github/workflows/github-pages.yml
Outdated
- name: Upload artifact | ||
uses: actions/upload-pages-artifact@v2 | ||
uses: actions/upload-pages-artifact@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only v3 exists for now - see https://github.com/actions/upload-pages-artifact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rianbrooksflynn! I'll clean this up. The repo is long overdue for an update - I am planning on replacing the build system soon with either vite or next too.
No breaking changes introduced.