llama3.1-8b: use TokensPrompt in the Offline vLLM SUT and fail fast on worker death - #2670
Open
100-JM wants to merge 1 commit into
Open
llama3.1-8b: use TokensPrompt in the Offline vLLM SUT and fail fast on worker death#2670100-JM wants to merge 1 commit into
100-JM wants to merge 1 commit into
Conversation
… worker death
SUT.process_queries (Offline) called LLM.generate(prompt_token_ids=...),
a keyword that newer vLLM releases no longer accept:
TypeError: LLM.generate() got an unexpected keyword argument
'prompt_token_ids'
SUTServer already passes pre-tokenized input as TokensPrompt objects,
which works on both the pinned vllm==0.6.3 and current releases, so the
Offline path now does the same. No change in what is sent to the model.
The TypeError also exposed a second problem: the exception only killed
the worker thread. LoadGen kept waiting for responses that would never
arrive and the run sat idle until the job's wall-clock limit (four hours
in our case) instead of failing. process_queries in both SUTs now wraps
the worker loop, logs the traceback and exits the process, so a broken
SUT fails the run immediately.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
MLCommons CLA bot: |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SUT.process_queries(Offline) inlanguage/llama3.1-8b/SUT_VLLM.pycallsprompt_token_ids=was a deprecated keyword that newer vLLM releases no longer accept. On vLLM 0.10.2 (NGCvllm:25.10-py3):SUTServeralready passes pre-tokenized input asTokensPromptobjects, which works on both the pinnedvllm==0.6.3and current releases; only the Offline path was left on the old form.The exception also exposed a second problem: it only killed the worker thread. LoadGen kept waiting for responses that would never arrive and the run sat idle until the job's wall-clock limit — four hours in our case — instead of failing.
Changes
[TokensPrompt(prompt_token_ids=...) for q in qitem]and passes it positionally, exactly asSUTServerdoes. Same tokens reach the model; no behavioural change on 0.6.3.process_queriesin both SUTs now wraps the worker loop: on an unhandled exception it logs the traceback andos._exit(1)s, so a broken SUT fails the run immediately instead of hanging LoadGen. If maintainers would rather keep the harness hands-off here, the first change stands alone.Verification
nvidia/Llama-3.1-8B-Instruct-NVFP4) with the equivalent patch —generate([{"prompt_token_ids": ids}, …]), i.e. the same dictTokensPromptconstructs: performanceVALID, accuracy run completes and passes all five evaluation metrics (ROUGE1/2/L/Lsum and gen_len above the 99% thresholds). The fail-fast wrapper was exercised only by the original TypeError run, where the thread died and LoadGen waited four hours.python -m py_compileandautopep8 -a --max-line-length 79clean. I could not exercisevllm==0.6.3itself, butTokensPrompthas existed since 0.4.x and is whatSUTServeralready uses on that version.Related: #2341 (Server/SingleStream
EngineDeadError) is a different failure in the same file and is not addressed here.🤖 Generated with Claude Code