Skip to content

fix: NameError 'has_reranker' in e2e-rag single-shot result display #2667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anai-Guo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: NameError 'has_reranker' in e2e-rag single-shot result display #2667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e-rag/evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def evaluate_retrieval_query(rag_db, query: str, expected_urls: List[str],
print("-" * 50)

# Show reranked results if reranker is available and reranking was used
if not no_rerank and has_reranker:
if not no_rerank and hasattr(rag_db, '_reranker_model') and rag_db._reranker_model is not None:
print(f"\nReranking to top-{top_k_reranking}")
print(f"Reranking results:")

Expand Down
Loading