Skip to content

Fix two NameErrors in the e2e-rag reference implementation #2664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
David-Wu1119 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix two NameErrors in the e2e-rag reference implementation #2664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions e2e-rag/evaluation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,10 @@ def evaluate_retrieval_query(rag_db, query: str, expected_urls: List[str],

# Step 2: Apply reranking if enabled and reranker is available
reranking_time = 0.0
if not no_rerank and hasattr(
rag_db, '_reranker_model') and rag_db._reranker_model is not None:
has_reranker = (
getattr(rag_db, '_reranker_model', None) is not None
)
if not no_rerank and has_reranker:
# Safety check: If no results retrieved, skip reranking
if not results:
if verbose:
Expand Down
6 changes: 3 additions & 3 deletions e2e-rag/reference_SUT_datasetup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@
from text_splitter import split_into_fixed_passages
from utils import get_device_config, load_url_mapping, get_base_filename

logging.basicConfig(level=logging.INFO)
log = logging.getLogger("DatasetupSUT")

# Import HTML extractor
try:
from bs4 import BeautifulSoup
Expand All @@ -46,9 +49,6 @@
HAVE_HTML = False
log.warning("BeautifulSoup not available - HTML processing disabled")

logging.basicConfig(level=logging.INFO)
log = logging.getLogger("DatasetupSUT")


class DatasetupSUT:
"""
Expand Down
Loading