Fix - #2660
Merged
Merged
Conversation
Remove llama2-70b-99 from the v6.1 config in submission_checker_old.py. #2651 removed llama2-70b-99 from the v6.1 block of the modular checker's constants.py but left the legacy submission_checker_old.py untouched, so the two configs disagreed about whether the model exists in v6.1. preprocess_submission.py imports submission_checker_old, and its infer_low_accuracy_results pass copies a -99.9 result to -99 whenever the low accuracy variant appears in config.required. Against the legacy v6.1 config that condition still held, so preprocessing recreated results/<system>/llama2-70b-99 from llama2-70b-99.9. The modular checker then ran over that directory, got None back from Config.get_required(), and died in lower_list() with "TypeError: 'NoneType' object is not iterable" - failing every round 6.1 closed submission generation CI job. This mirrors the #2651 deletions site for site; v6.0 and v5.1 keep the model. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
hanyunfan
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
llama2-70b-99from the v6.1 config intools/submission/submission_checker_old.py.Why
#2651 removed
llama2-70b-99from the v6.1 block of the modular checker'sconstants.py, but left the legacysubmission_checker_old.pyuntouched. The two configs then disagreed about whether the model exists in v6.1.preprocess_submission.pydoesimport submission_checker_old as checker, and itsinfer_low_accuracy_resultspass copies a-99.9result to-99whenever the low-accuracy variant is inconfig.required. Against the legacy v6.1 config that condition still held, so preprocessing recreated the model directory:The modular checker then walked that directory,
Config.get_required()returnedNonefor the unknown model, andlower_list(None)raised:That crashed all six
round=6.1/folder_name=closedsubmission generation jobs on every open PR. Round 6.0 passes because it legitimately still has the model, and the 6.1 open fixtures never reachcheck_scenarios()— it only runs for closed/network divisions.Change
Mirrors the #2651 deletions site for site —
models, bothrequired-scenarios-*andoptional-scenarios-*dicts,accuracy-target,accuracy-upper-limit,performance-sample-count,dataset-size,latency-constraint,min-queries, andmodels_TEST06. Same 21 lines, v6.1 only. v6.0 and v5.1 keep the model.Paired with a matching cleanup on the
submission-generation-examplesbranch (14c5196), which dropped the stalellama2-70b-99fixture fromsubmission_round_6.1/closed/. Both are needed: the fixture removal stops the raw directory being copied in, and this stops preprocessing from recreating it.Note
Worth considering as a follow-up:
check_scenarios()could treat aNonefromget_required()as an "unknown benchmark" error rather than letting it become a traceback. A submitter with a retired or misspelled model directory currently gets an unreadable stack trace and nosummary.csv, which then cascades into a secondFileNotFoundErrorfromgenerate_final_report.py.🤖 Generated with Claude Code