[Feature] Support compile_structural_tag and from_structural_tag with a Format as the parameter. #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuchuan <[email protected]>
Signed-off-by: Yuchuan <[email protected]>
Signed-off-by: Yuchuan <[email protected]>
Signed-off-by: Yuchuan <[email protected]>
Signed-off-by: Yuchuan <[email protected]>
Ubospica
reviewed
Oct 11, 2025
| stag_format: xgr.structural_tag.Format, instance: str, is_accepted: bool | ||
| ): | ||
| check_stag_with_instance_in_format_style(stag_format, instance, is_accepted) | ||
|
|
There was a problem hiding this comment.
Update with check_stag_with_instance
|
Close this because we need to send StructuralTag instead of Format to compiler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports
compile_structural_tagandfrom_structural_tagwith a Format as the parameter. For example, in the main branch, if we want to usefrom_structrual_tagwith aStructuralTag, we must:Now, we can:
And it should be more convinient.