feat(core): Support __replace__ in general
#26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `mlc.dataclasses.replace` method that mimics the behavior of Python's native `dataclasses.replace`. In principle, we do want something fully compatible with Python's native dataclass, but for now, there are certain limitations: - `__post_init__` will not be called upon replacement; - POD types, such as `mlc.DataType`, `mlc.Device`, do not support `__replace__`. Something we could always add support case by case if needed later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
mlc.dataclasses.replacemethod that mimics the behavior of Python's nativedataclasses.replace.In principle, we do want something fully compatible with Python's native dataclass, but for now, there are certain limitations:
__post_init__will not be called upon replacement;mlc.DataType,mlc.Device, do not support__replace__. Something we could always add support case by case if needed later