Implementation of JMove algorithm #49
Conversation
… from MethodEntity and other way around)
…added localVariables set into Dependencies
…ding new statements + a little renaming
| || isSetter(curMethod)) //todo: check if we need this check here and not in other place | ||
| continue; | ||
| double curSimilarity = calculateSimilarity(curMethod, curClass, nameToDependencies); | ||
| Map<ClassEntity, Double> potentialClasses = new HashMap<>(); |
There was a problem hiding this comment.
there is no need to store all potential target classes, you can simply introduce counter variable and use single potential class entity
| } | ||
|
|
||
| private boolean fromUtilOrLang (String fullName) { | ||
| if(fullName.startsWith("java.lang.") || fullName.startsWith("java.util.")) |
There was a problem hiding this comment.
return fullName.startsWith("java.lang.") || fullName.startsWith("java.util.")
|
When specifying remote branch for push you should not put remote name there.
|
|
INFO [org.ml_methods_group.algorithm.Algorithm.execute] - JMove started |
(plus there are a lot of commented lines for debuging)
JMove algorithm suggests Move Method refactoring using static dependencies established by methods.
Thiss an implementation of this algorithm and dependencies sets. The ability of making suggested refactorings is not checked wich may be an issue.