Improve src_rect handling in sprites, and especially the wave effect #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…too-large dimensions, and fix some behavior in wave effects. src_rects like these probably aren't used in any game, but I plan on using them for megasurface support. Additionally, src_rects in sprites with active wave effects were apparently broken before, always treating the position as (0,0). I'm also fixing a small bug in how the wave position was calculated, and a slightly larger one in how it handles zooming.
Sprites with a negative wave_amp should be horizontally squished toward their center, not cropped.
|
I took another look at this and added proper negative wave amp support, fixed high res bitmap support, and fixed some other issues with the original commit. That first commit should probably be two commits, but I'm too lazy to fix it. Fixes #189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us properly handle src_rects that extend beyond the bounds of the bitmap. I doubt it's used much if it all in the wild, but I'm making use of it for my next PR...
Also, apparently the wave effect wasn't using src_rect's position at all. I'm amazed it took this long to get noticed.
Fixes #189