Fix synchronizing #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
force-pushed
the
fix-deserialize
branch
from
3669fcb to
2b55b52
Compare
mkroening
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
Unfortunately with the latest release the software has stopped working (for me?). When deserializing an
AccountConfigfrom inside a tokio runtime, the app panics because you can't callblock_oninside an async execution thread. This would be the case for example when runningedu-sync-cli sync.I have made the whole path deserializing synchronous. I don't think it makes a ton of sense to have this asynchronous anyways.