Skip to content

Conversation

cignoni
Copy link

@cignoni cignoni commented Nov 12, 2015

  • _DepthAndOffset requires node as first parameter
  • diagonal is a pointer so -> instead of .

@cignoni
Copy link
Author

cignoni commented Nov 12, 2015

Hi, I was compiling the latest version on my mac and I got these two small errors, probably they are in unused branches of the basecode but clang is quite pedant...
Cheers
Paolo

@cignoni
Copy link
Author

cignoni commented Oct 13, 2016

Updated the pull request.
Now this pull request contains only a .pro file (useful for qtcreator addicted guys) and two minor modifications to Src/MultiGridOctreeData.h (missing omp guards and a this-> requested by clang)

@dgirardeau
Copy link

I confirm that this PR works perfectly, even with the 9.1 version. It successfully compiles on Visual 2013, g++ and clang.

@abellgithub
Copy link

abellgithub commented May 12, 2017

I'm not sure what you were seeing for line 339 in Src/MultiGridOctreeData.h, but I think Data can be a raw pointer (depending on the memory debugging setting), in which case taking size() makes no sense. I think _sz should be used instead.

Update: that function isn't called anyway, so it's irrelevant. Could be commented out or removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants