Input output #29
Open
Input output #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to make clang compiler happy.
…dently of auxiliary code.
…ttempt past end of array. Simplify vector getSolutions() by calling pointer variant.
Break into subroutines of some reasonable size. Start to get rid of C-like code.
Simplify PointStream -> PointSource.
SSDRecon now uses PointSource.
Pass boolean arguments to PoissonRecon options.
Point source code into a directory.
- uncommented the _WIN32 #ifdef in PoissonRecon.cpp, which also required the addition of NOMINMAX preprocessor definition - missing #include <memory> in PoissonRecon.h - removed 'template' keyword in PoissonRecon.h
- added OMP critical section to MyMesh - also changed the default number of threads to omp_get_num_procs()
added casts and removed unused variables
Input output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guts of this separate the algorithm from the driver code. It allows one to create an interface to the poisson surface reconstruction as they please. It breaks the dependence on the PLY format for output and simplifies the input handling.
There are also lots of casts to handle compiler type-incompatibility warnings.