Repository navigation
Include source positions in errors - #14
Merged
Merged
Conversation
Parsers now use an `offset` rather than the `remainingInput` to keep track of what to parse next, which allows failures to say exactly where parsing got stuck. Additionally, `InvalidInputError` can now contain a list of expected values, and `oneOf` returns the failure(s) that reached the furthest offset rather than the error from whichever parser was tried last. This makes backwards-incompatible changes to parse results (`offset` replaces `remainingInput`), so the next release should have a major version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsers now use an
offsetrather than theremainingInputto keep track of what to parse next, which allows failures to say exactly where parsing got stuck.Additionally,
InvalidInputErrorcan now contain a list of expected values, andoneOfreturns the failure(s) that reached the furthest offset rather than the error from whichever parser was tried last.This makes backwards-incompatible changes to parse results (
offsetreplacesremainingInput), so the next release should have a major version bump.