Merge pull request #565 from olleolleolle/refactor/memoize-return-val…

…ues-docker-base [Refactoring] Memoize without duplication
mizzy · Apr 28, 2016 · 319c48e · 319c48e
2 parents 79751f8 + 196a23a
commit 319c48e
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/lib/serverspec/type/docker_base.rb b/lib/serverspec/type/docker_base.rb
@@ -16,14 +16,12 @@ def [](key)
     end
 
     def inspection
-      return @inspection if @inspection
-      @inspection = ::MultiJson.load(get_inspection.stdout)[0]
+      @inspection ||= ::MultiJson.load(get_inspection.stdout)[0]
     end
 
     private
     def get_inspection
-      return @get_inspection if @get_inspection
-      @get_inspection = @runner.run_command("docker inspect #{@name}")
+      @get_inspection ||= @runner.run_command("docker inspect #{@name}")
     end
   end
 end