Skip to content
This repository was archived by the owner on May 8, 2020. It is now read-only.

Fixes (ignores) SSL certificate error on Windows - #227

Open
tpberntsen wants to merge 1 commit into
miyakogi:devfrom
tpberntsen:dev
Open

tpberntsen wants to merge 1 commit into
miyakogi:devfrom
tpberntsen:dev

Conversation

@tpberntsen

@tpberntsen tpberntsen commented Jun 4, 2019 •

Copy link
Copy Markdown

Adds explicit ignoring of SSL certificate errors when downloading Chromium either when running the first time or through pyppeteer-install to avoid the following error (on Win x64):

SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1056)'))

Adds explicit ignoring of SSL certificate errors when downloading Chromium with pyppeteer-install.
@codecov-io

codecov-io commented Jun 4, 2019 •

Copy link
Copy Markdown

Codecov Report

Merging #227 into dev will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #227      +/-   ##
==========================================
- Coverage   92.38%   92.34%   -0.05%     
==========================================
  Files          48       48              
  Lines        7105     7105              
==========================================
- Hits         6564     6561       -3     
- Misses        541      544       +3
Impacted Files Coverage Δ
pyppeteer/chromium_downloader.py 39.28% <0%> (ø) ⬆️
tests/test_frame.py 96.53% <0%> (-0.65%) ⬇️
pyppeteer/network_manager.py 92.1% <0%> (-0.27%) ⬇️
pyppeteer/execution_context.py 93.33% <0%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56f8710...47ea43c. Read the comment docs.

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants