-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Traktor S4MK3: Add alternative modes for a few controls. #15664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Relative Tempo Fader mode: Tempo fader only responds to changes, not absolute position. Use shift to change position without adjusting rate. Relative Tempo Fader, Shifted mode: Only respond to changes when shift is held. Prevents accidental bumps when DJing in poor tactile environments (wearing fursuit paws) Jog Wheel Adjustment factor: Adjust sensitivity of jog wheel when making sync adjustments. Alternative Mode mode: for the move encoder, change assignments: unshifted to change beatjump size, shift to do a beatjump, push and change to adjust pitch. Signed-off-by: Owen Williams <[email protected]>
|
Thank you for this! The relative tempo mode is indeed helpful, for me when I want to match another track's BPM which is > +- 8% but I don't want to change the rate range. Though there are a few issue with the current implementation:
How can we implement a 'relative mode' toggle? |
(see below)
what would you want them to do here?
I can clamp that for sure. And an upper bound just for safety seems useful too.
I'll think about this -- currently I think it's ok to keep it as a controller setting and not something accessible from the controller hardware. |
|
I guess shift+jog can work? But I think "shift+master long press" is available: https://github.com/mixxxdj/mixxx/blob/main/res/controllers/Traktor-Kontrol-S4-MK3.js#L1989-L1998 |
* clamp values to sane min and max * use shift+master-long-press to toggle per-deck relative setting Signed-off-by: Owen Williams <[email protected]>
Actually I was missing the center indictaor, but that's d be kind of useless anyway because, without the (scripted) center zone, the center can actually not be reached. Will test the latest update soonish. |
|
I suppose we could light up the light when the pitch is zero, regardless of where the slider is. (That would show how far off from centered the slider is) |
|
Yeah, thing is, what I tried to explain: with the high-res faders I never managed to hit zero -- that's why I added the center zone #14735, and with relative mode we currently don't have this center zone. Is there a way to engage relative mode on request? And auto-quit?
(1) I suspect the crucial/tricky part would be to distinguish rate changes done by the engine (sync locked) and the physial fader Kind of related to #14985 |
is the goal here "I want to reset the pitch to zero"? I think that could be accomplished by moving the physical fader to the center, disabling relative mode and reengaging relative mode. Personally I would just right-click on the screen to do this rather than try to do it with the controller. If you can say more about the use-case for this it would help me understand. I don't quite understand what would be happening in a DJ set that you want to do. |
|
Right. First of all, I'm not requesting to expand the scope here. Relative mode is nice, even if it can only be toggled in the settings. My use case is beat matching to external sources. I usually try to match by ear or use a BPM tap tool. What (in my mind) would feel natural is moving the fader to the upper/lower limit, Shift-move it back to (somewhere near) the center and continue in relative mode. And later on return to absolute mode as described. |
Relative Tempo Fader mode: Tempo fader only responds to changes, not absolute position. Use shift to change position without adjusting rate. (great for sync lock mode)
Relative Tempo Fader, Shifted mode: Only respond to changes when shift is held. Prevents accidental bumps when DJing in poor tactile environments (wearing fursuit paws)
Jog Wheel Adjustment factor: Adjust sensitivity of jog wheel when making sync adjustments. (current default is very sensitive)
Alternative Move mode: for the move encoder, change assignments: unshifted to change beatjump size, shift to do a beatjump, push and change to adjust pitch. (another case where I don't want to accidentally bump the control and jump beats)