Skip to content

Conversation

@mxmilkiib
Copy link
Contributor

Description

Adds a controllable parameter for adjusting the horizontal position of the playback marker/line on waveforms, allowing users to customize where the playback position indicator appears.

Motivation

Users may prefer different playback marker positions for various workflows:

  • DJs mixing may prefer the marker further right to see more upcoming audio
  • Radio DJs may prefer it centered or left for different visual reference
  • Users with ultrawide monitors may want to adjust position for ergonomics

This addresses feature request #14288.

Changes

  • Adds [Waveform],play_marker_position control (range: 0.0 = left, 1.0 = right)
  • Implements ControlPotmeter in WaveformWidgetFactory for smooth value adjustment
  • Exposes control in controller picker menu for MIDI/HID mapping
  • Adds tooltip documentation for the control
  • Preserves existing playback marker position functionality from preferences

Technical Implementation

The control is implemented as a global waveform setting that:

  • Persists across sessions via configuration
  • Updates all active waveform widgets when changed
  • Integrates with the existing playback marker rendering system in WaveformWidgetRenderer
  • Follows Mixxx control object patterns (snake_case naming for mappable controls)
  • Complements the existing preferences slider without replacing it

Testing

  • Code compiles successfully
  • Control is accessible via MIDI/HID mapping
  • UI preferences slider continues to work
  • Position persists across application restarts
  • All waveform widgets update when control changes

Related Issue

Fixes #14288

Implements control for adjusting the horizontal position of the playback marker/line over waveforms.

- Adds [Waveform],PlayMarkerPosition control (0.0 = left, 1.0 = right)
- Creates ControlPotmeter for smooth value adjustment
- Exposes control in controller picker menu for MIDI/HID mapping
- Adds tooltip for the control
- Preserves existing playback marker position functionality

Fixes mixxxdj#14288
@mxmilkiib mxmilkiib force-pushed the feature/2025.11nov.16-playback-position-control branch from a86c404 to 9abc3ea Compare November 16, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Control to control the Playback Marker's position?

1 participant