add checkbox to hide unenabled controllers in preferences #15580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds a checkbox in preferences > controllers to hide controllers that are not enabled, making it easier for users with many controllers to find the ones they actually use. the checkbox state is persisted in the config and the controller list visibility is updated efficiently using setHidden() to avoid expensive widget rebuilding. implementation: - added checkbox ui element "hide controllers that are not enabled" - persists state in [controller]/hide_unenabled_controllers config key - uses lightweight updatecontrollervisibility() method to toggle tree item visibility instead of destroying/rebuilding all widgets - matches controllers correctly using controller pages in sync with tree items - updates visibility automatically when controller enabled state changes - added controller() getter to dlgprefcontroller for proper matching fixes mixxxdj#14275
mxmilkiib
force-pushed
the
feature/2025.11nov.05-hide-unenabled-controllers
branch
from
ba6f6e0 to
7c87579
Compare
ronso0
reviewed
Nov 17, 2025
| QTreeWidgetItem* pTreeItem = m_controllerTreeItems.at(i); | ||
| DlgPrefController* pControllerDlg = m_controllerPages.at(i); | ||
|
|
||
| if (pTreeItem && pControllerDlg && pControllerDlg->controller()) { |
Member
There was a problem hiding this comment.
The DlgPrefController ctor does not assert a valid Controller* and there are no issues with that so I think we don't to check here either
Suggested change
| if (pTreeItem && pControllerDlg && pControllerDlg->controller()) { | |
| if (pTreeItem && pControllerDlg) { |
| #endif | ||
|
|
||
| const ConfigKey kHideUnenabledControllersCfgKey = | ||
| ConfigKey(QStringLiteral("[Controller]"), QStringLiteral("hide_unenabled_controllers")); |
Member
There was a problem hiding this comment.
I don't remember I ever came across "unenabled"?
Wh< not "disabled"?
Suggested change
| ConfigKey(QStringLiteral("[Controller]"), QStringLiteral("hide_unenabled_controllers")); | |
| ConfigKey(QStringLiteral("[Controller]"), QStringLiteral("hide_disabled_controllers")); |
Member
There was a problem hiding this comment.
For consistency, same for the config keys, function names and UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a checkbox in Preferences > Controllers to hide controllers that are not enabled, making it easier for users with many controllers to find the ones they actually use.
the checkbox state is persisted in the config and the controller list visibility is updated efficiently using setHidden() to avoid expensive widget rebuilding.
implementation:
fixes #14275