add quick access to controller learning wizard via options menu #15577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxmilkiib
force-pushed
the
feature/2025.11nov.04-controller-wizard-quick-access
branch
from
bb8a876 to
6546404
Compare
ronso0
reviewed
Nov 5, 2025
Comment on lines
+299
to
+318
| // Temporarily disconnect the mappingEnded signal to prevent | ||
| // showing the preferences dialog when the wizard closes | ||
| disconnect(pControllerDlg, | ||
| &DlgPrefController::mappingEnded, | ||
| m_pDlgPreferences, | ||
| &DlgPreferences::show); | ||
|
|
||
| // Reconnect after wizard closes to restore normal behavior | ||
| connect( | ||
| pControllerDlg, | ||
| &DlgPrefController::mappingEnded, | ||
| this, | ||
| [this, pControllerDlg]() { | ||
| // Restore the connection for future uses from preferences | ||
| connect(pControllerDlg, | ||
| &DlgPrefController::mappingEnded, | ||
| m_pDlgPreferences, | ||
| &DlgPreferences::show); | ||
| }, | ||
| Qt::SingleShotConnection); |
Member
There was a problem hiding this comment.
why do we need to disconnect this?
when a new mappng has been added, the mapping needs to be saved/applied, no?
Contributor
Author
There was a problem hiding this comment.
stops prefs reopening
"disconnect only affects UI flow, not saving. prevents preferences dialog popping up when wizard is launched from menu instead of from within preferences. saving/applying happens in 'slotStopLearning()' before mappingEnded emits. single-shot reconnect restores normal behavior for preference-based launches."
maybe there is a more elegant way?
implements feature request from issue mixxxdj#12262 to provide quicker access to the midi controller learning wizard. ## changes ### options menu submenu - added "controller learning wizard" submenu under options menu - dynamically populated with enabled controllers only - shows "no controllers enabled" when no controllers are enabled - updates automatically when controllers are enabled/disabled ### navigation - clicking a controller menu item opens preferences dialog - automatically navigates to that specific controller's page - expands the controllers tree and selects the correct item - user can then click the "learning wizard" button on that page ### implementation - wmainmenubar: added menu creation and signal emission - mixxxmainwindow: connected signals, filters to show only enabled controllers - dlgprefcontrollers: added method to navigate to specific controller - dlgpreferences: added method to delegate to controllers dialog follows the same architectural pattern as the existing vinyl control menu implementation for consistency. fixes mixxxdj#12262
mxmilkiib
force-pushed
the
feature/2025.11nov.04-controller-wizard-quick-access
branch
from
6546404 to
2978aa3
Compare
ronso0
requested changes
Nov 16, 2025
Comment on lines
+296
to
+298
| for (int i = 0; i < m_controllerPages.size(); ++i) { | ||
| DlgPrefController* pControllerDlg = m_controllerPages.at(i); | ||
| if (pControllerDlg && pControllerDlg->controller() == pController) { |
Member
There was a problem hiding this comment.
Suggested change
| for (int i = 0; i < m_controllerPages.size(); ++i) { | |
| DlgPrefController* pControllerDlg = m_controllerPages.at(i); | |
| if (pControllerDlg && pControllerDlg->controller() == pController) { | |
| for (auto* pControllerDlg : m_controllerPages) { | |
| if (pControllerDlg->controller() == pController) { |
Comment on lines
+307
to
+308
| connect( | ||
| pControllerDlg, |
Member
There was a problem hiding this comment.
Suggested change
| connect( | |
| pControllerDlg, | |
| connect(pControllerDlg, |
| // Show "No controllers enabled" if list is empty | ||
| if (m_controllerLearningActions.isEmpty()) { | ||
| auto* pNoControllersAction = new QAction(tr("No controllers enabled"), this); | ||
| pNoControllersAction->setEnabled(false); |
Member
There was a problem hiding this comment.
This doesn't seem to work (here, with Qt 6.2.3), action is still enabled, can be selected and clicked
| Qt::UniqueConnection); | ||
| // Initialize the menu with current controllers | ||
| slotUpdateControllerLearningMenu(); | ||
| } |
Member
There was a problem hiding this comment.
This doesn't work as intended, I don't see updated after startup.
The funtion that emits devicesChanged clearly states:
mixxx/src/controllers/controllermanager.cpp
Lines 191 to 193 in 604b32c
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements feature request from issue #12262 to provide quicker access to the midi controller learning wizard.
changes
options menu submenu
navigation
implementation
follows the same architectural pattern as the existing vinyl control menu implementation for consistency.
fixes #12262