Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another method to create a REST Client using a configurable http.client object #181

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

simbou2000
Copy link

The current methods doesn't allow to configure some of the TLS options, such as to configure certificates/CAs to use (In case these are not available in the default go's lookup paths), to ignore certificate verification, among other ones.

Simon Bouchard added 2 commits October 31, 2023 18:25
Copy link
Collaborator

@elenz97 elenz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the PR! 👍

@elenz97 elenz97 merged commit bf1598d into mittwald:master Nov 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants