Fix epsilon issue for volpath integrators #785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvicini
force-pushed
the
volpath_epsilon_fix
branch
from
cda0d5d to
9b22128
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The volpath integrators currently seem to have a small epsilon issue due to the use of
ref_interaction.spawn_rayinstead ofref_interaction.spawn_ray_to. The latter computes a better/more generous shadow epsilon. Therefore, replacing this call and the use of the previous shadow epsilon fixes the epsilon issue.For renderings showcasing the problem, see #678 (towards the bottom of the thread)