fix: drawing structured addresses #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the [Swiss QR-bill specification][1], a structured address (type S) has `line1` representing the _street name_ and `line2` representing the _street number_. When a structured address is provided, the library currently prints `line1` and `line2` on two separate lines. However, for type S addresses, `line1` and `line2` should be printed combined on a single line. While it is possible to provide the _street name_ and _number_ combined in `line1` as a workaround, most e-banking software expects these to be separate. Otherwise, the software may not populate its form correctly, causing unnecessary friction in the payment process. [1]: https://www.six-group.com/dam/download/banking-services/standardization/qr-bill/ig-qr-bill-v2.2-en.pdf
|
Thank you very much for your effort and finding this issue. I will merge it as soon as possible. BTW: I just saw, starting from Nov 2025 only structured address types are valid. Combined addresses are getting removed:
Source: Swiss QR-bill spec, V2.3 |
|
Oh, I wasn't aware that combined addresses are being phased out. Good to know. 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Swiss QR-bill specification, a structured address (type S) has
line1representing the street name andline2representing the street number. When a structured address is provided, the library currently printsline1andline2on two separate lines. However, for type S addresses,line1andline2should be printed combined on a single line.While it is possible to provide the street name and number combined in
line1as a workaround, most e-banking software expects these to be separate. Otherwise, the software may not populate its form correctly, causing unnecessary friction in the payment process.