Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old-style print calls in setup.py (fix install with Py3) #60

Closed
wants to merge 1 commit into from

Conversation

GuillaumeDerval
Copy link
Contributor

@GuillaumeDerval GuillaumeDerval commented Jul 31, 2016

Old-style prints currently make impossible to install PyLTI with Python 3

(there are other issues with Py3, but I'm investigating :-) )

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a4a2fd4 on GuillaumeDerval:py3 into 3266843 on mitodl:master.

@pdpinch
Copy link
Member

pdpinch commented Jul 31, 2016

@amir-qayyum-khan would you mind reviewing this?

@GuillaumeDerval
Copy link
Contributor Author

For info, there is a problem with an old library (oauth) that is not compatible with Py3, I'm attempting to convert PyLTI to oauth2 (which is a fork of the original oauth, and still implements OAuth 1, despite the name).

I do not really understand why PyLTI has currently a dependency on both oauth and oauth2, as they do exactly the same thing... Is there a particular reason?

@amir-qayyum-khan
Copy link
Contributor

sure let me

On Aug 1, 2016 1:15 AM, "Peter Pinch" [email protected] wrote:

@amir-qayyum-khan https://github.com/amir-qayyum-khan would you mind
reviewing this?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#60 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJ8rEpmawbiCRv8mBQr4d_DbTvsRHlLtks5qbQJ4gaJpZM4JZGRj
.

@GuillaumeDerval
Copy link
Contributor Author

I spent some hours to make PyLTI pass the tests again with Python 3 (tested with 2.7, 3.4 and 3.5, I'm not sure it will pass with Python 3.1, 3.2 and 3.3 since they don't support the u prefix from what I remember):

https://github.com/GuillaumeDerval/pylti/tree/py3-restore

However, I have not tested if it works in any practical situation. I'll make some tests in the following days, then I'll open a PR.

I dropped oauth, since oauth2 is a fork, but oauth2 itself has some problems, which I had to fix manually (see classes SignatureMethod_HMAC_SHA1_Unicode, SignatureMethod_PLAINTEXT_Unicode, Request_Fix_Duplicate) (joestump/python-oauth2#207 joestump/python-oauth2#197).

There are a lot of problems with encoding everywhere.

It also fixes #58

@GuillaumeDerval
Copy link
Contributor Author

close in favor of #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants