Pass in Python callback to native FlightSQLServer, invoke in GetFlightInfoStatement #492
Conversation
sopzha
commented
Apr 16, 2024
sopzha
commented
- Create in-memory map to store and retrieve query data, using efficient concurrent hash table from libcuckoo
- Build schema from query result field types
…tInfoStatement, DoGetStatement
…g from query field types
…ect map with mutex in brad_server_simple
…r<std::any>, use placeholder value in query_data map
…vector<std::any>> type
There was a problem hiding this comment.
Thanks @sopzha! I think this PR is almost there. The main thing left is to implement something similar to BradStatement::FetchResult() to actually convert the query result into the Arrow format. I left comments with pointers - please let me know if anything is confusing and I can explain more!
|
Thank you so much Geoffrey for the thorough review!! Made a first pass thru the comments and will review changes again tomorrow. Feel free to add any additional comments / lmk if I missed anything! I will store RecordBatch in BradStatement in a future PR. |
| @@ -5,8 +5,16 @@ | |||
| #include <string> | |||
|
|
|||
| #include <arrow/flight/sql/server.h> | |||
| #include "brad_statement.h" | |||
| #include <arrow/result.h> | |||
|
|
|||
There was a problem hiding this comment.
(Another minor thing:) We should still have the includes for atomic and functional (since they are used in this class) 😄. We should add #include <vector> and #include <string> too. My previous comment was referring to removing mutex since we aren't using it in the class anymore.
